feat: add --image-parallel-copies flag
#2277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atry
force-pushed
the
max-parallel-downloads
branch
3 times, most recently
from
5d1622f to
98312aa
Compare
mtrmac
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Thanks!
Compare containers/image#1968 ; that might, or might not, also have a noticeable effect for that use case.
(Hypothetically even to the point of making this option unnecessary? I think that’s unlikely, but worth measuring.)
Atry
force-pushed
the
max-parallel-downloads
branch
2 times, most recently
from
2f08be9 to
955a81d
Compare
Atry
changed the title
--max-parallel-downloads flag--image-parallel-copies flag
mtrmac
reviewed
Apr 2, 2024
Atry
force-pushed
the
max-parallel-downloads
branch
from
955a81d to
db8701c
Compare
Both PRs can speed up |
|
@Atry Looks like this needs a rebase. |
Atry
force-pushed
the
max-parallel-downloads
branch
from
4948a7c to
e9a930d
Compare
|
Rebased |
|
LGTM |
Signed-off-by: Yang, Bo <[email protected]>
mtrmac
force-pushed
the
max-parallel-downloads
branch
from
e9a930d to
1c72e39
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful when there are many layers while most of layers are unchanged between versions.
See discussion at nlewo/nix2container#125